William,
Thanks for the review.
On 07/07/11 16:14, William Schumann wrote:
Matt,
varshared.py:
Do any 'raise exception' messages need to be localized?
I've looked at the rest of the code under install_targets, and none of
the existing exceptions are localized, so I don't think so.
78: will get_descendants method always return a list with at least one
element?
get_descendants could return None, but this does not impact the code in
any manner, as these lists are used for searching through via for loops,
if the list is None, then for loop will not be processed, which is
catered for.
125, 129: 'as could not' not clear to me. Should Filesystem be
capitalized here?
"as could not, is indicating that the root pool was not locatable.
Entire message would read :
"Failed to add 'var' in_be Filesystem as could not locate root pool"
I could change to :
"Failed to add 'var in_be Filesystem object, as the root pool could
not be found."
Filesystem is capitalized as that is the actual name of the object being
added.
155 "non root pool" -> "non-root pool"
Done
PEP8 states that blank lines should be used sparsely, but that doesn't
seem to be the norm for the install consolidation anyhow...
When I run pep8 on varshared.py I don't get any warning whatsoever... :-)
cheers
Matt
William
On 07/ 7/11 04:31 PM, Matt Keenan wrote:
Hi,
Can I get a code review for bugs :
7048015 Automated Installer should create a separate /var and shared area
7049157 Text installer should create a separate /var and shared area
7049160 GUI installer should create a separate /var and shared area
http://monaco.sfbay.sun.com/detail.jsf?cr=7048015
Webrev :
https://cr.opensolaris.org/action/browse/caiman/mattman/7048015.7049157.7049160
All three installers need to create /var within the installed BE and
/var/shared globally available. This is achieved by adding two
Filesystem objects to the DESIRED root Zpool object before Target
Instantiation is called. TI will then simply create them.
A new checkpoint "VarSharedDataset" is being created to handle the
additions, and will be called by all three installers.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
