Matt,
varshared.py LGTM, never mind modifying the log message. Responses below.
On 07/ 7/11 05:42 PM, Matt Keenan wrote:
William,
Thanks for the review.
On 07/07/11 16:14, William Schumann wrote:
...
125, 129: 'as could not' not clear to me. Should Filesystem be
capitalized here?
"as could not, is indicating that the root pool was not locatable.
Entire message would read :
"Failed to add 'var' in_be Filesystem as could not locate root pool"
OK, makes sense to me now. Never mind.
I could change to :
"Failed to add 'var in_be Filesystem object, as the root pool could not be
found."
Filesystem is capitalized as that is the actual name of the object being added.
...
PEP8 states that blank lines should be used sparsely, but that doesn't
seem to be the norm for the install consolidation anyhow...
When I run pep8 on varshared.py I don't get any warning whatsoever... :-)
:) http://www.python.org/dev/peps/pep-0008/
William
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
