solaris_install/__init__.py: Just to be a nit, pep8/pep257 call for having the blank line before closing the docstring.
Other than that, the partial() stuff looks great! - Keith On Mon, Jul 11, 2011 at 1:02 PM, Drew Fisher <[email protected]> wrote: > Good afternoon! > > Could I please get a code review for the following CRs: > > 7046402 <http://monaco.us.oracle.com/detail.jsf?cr=7046402> provide a > functools.partial object for common Popen.check_call invocations > 7065597 <http://monaco.us.oracle.com/detail.jsf?cr=7065597> update DC to > use solaris_install.Popen > > https://cr.opensolaris.org/action/browse/caiman/drewfish/cr_7046402/webrev/ > > I successfully built all 3 x86 ISOs (based on 169) and fully installed each > of them with no problems. > > Thanks! > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > -- Join me in the fight to end AIDS! http://www.tofighthiv.org/goto/kemitche
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
