Hi Drew,
I have a few minor comments.
usr/src/cmd/distro_const/checkpoints/create_iso.py:
- line 168: add a debug logging statement before this to show the
command being executed,
or enhance the debug statement in line 165?
usr/src/cmd/distro_const/checkpoints/pkg_img_mod.py:
- line 192: why do we want to ignore the stderr?
- lines 194-199: did you mean to delete these lines?
- line 228: why ignore the error?
- lines 231-232: this is no longer needed since "run()" will log the
output, right?
Thanks,
--Karen
On 07/11/11 13:02, Drew Fisher wrote:
Good afternoon!
Could I please get a code review for the following CRs:
7046402 <http://monaco.us.oracle.com/detail.jsf?cr=7046402> provide a
functools.partial object for common Popen.check_call invocations
7065597 <http://monaco.us.oracle.com/detail.jsf?cr=7065597> update DC
to use solaris_install.Popen
https://cr.opensolaris.org/action/browse/caiman/drewfish/cr_7046402/webrev/
I successfully built all 3 x86 ISOs (based on 169) and fully installed
each of them with no problems.
Thanks!
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
