Hi Drew,
Everything look good to me now.
Thanks,
--Karen
On 07/11/11 15:55, Drew Fisher wrote:
Karen,
On 7/11/11 4:36 PM, Karen Tung wrote:
Hi Drew,
I have a few minor comments.
usr/src/cmd/distro_const/checkpoints/create_iso.py:
- line 168: add a debug logging statement before this to show the
command being executed,
or enhance the debug statement in line 165?
I added the debug logging statement back.
usr/src/cmd/distro_const/checkpoints/pkg_img_mod.py:
- line 192: why do we want to ignore the stderr?
We used to want to! With the redirection of stderr to the log AND
setting the loglevel to DEBUG we suppress this message:
2011-07-11 14:52:38,323 InstallationLogger DEBUG Warning:
creating filesystem that does not conform to ISO-9660.
Which was very misleading to users.
I changed it to simply say: run(cmd)
which does the right thing.
- lines 194-199: did you mean to delete these lines?
*sigh* Yes I did. I meant to put the XXX comment there so I would be
sure to spot this before sending to caimain-discuss. It clearly
worked well. They're removed now.
- line 228: why ignore the error?
See above.
- lines 231-232: this is no longer needed since "run()" will log the
output, right?
Correct. Forgot to remove these as well.
I updated the webrev here:
https://cr.opensolaris.org/action/browse/caiman/drewfish/cr_7046402_2/webrev/
Can you take a quick peek?
Thanks, Karen!
-Drew
Thanks,
--Karen
On 07/11/11 13:02, Drew Fisher wrote:
Good afternoon!
Could I please get a code review for the following CRs:
7046402 <http://monaco.us.oracle.com/detail.jsf?cr=7046402> provide
a functools.partial object for common Popen.check_call invocations
7065597 <http://monaco.us.oracle.com/detail.jsf?cr=7065597> update
DC to use solaris_install.Popen
https://cr.opensolaris.org/action/browse/caiman/drewfish/cr_7046402/webrev/
I successfully built all 3 x86 ISOs (based on 169) and fully
installed each of them with no problems.
Thanks!
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
