Hi Dave --
Yes. That's actually why I decided to limit the code review to
only this bug. I didn't feel that it really addressed the others:
7066541 ( the zones log collisions)
7033341 (a request to remove /var/tmp as the default loc)
Thanks...this reminded me that I forgot to mention that the C side will
be updated separately
when I get back from vacation. I just filed: 7076927
thanks,
ginnie
On 08/ 9/11 02:04 PM, Dave Miner wrote:
Ginnie, just to clarify, we'll still need to modify AI separately to
solve the issue around log collisions, right?
Dave
On 08/09/11 15:43, Virginia Wray wrote:
Hi --
Could I get a code review for the following bug:
http://monaco.us.oracle.com/detail.jsf?cr=7033339
Be able to specify logfile name when instantiate InstallLogger
_<http://monaco.us.oracle.com/detail.jsf?cr=7033339>_
https://cr.opensolaris.org/action/browse/caiman/ginnie/7033339/webrev/
I've tested the changes with the distro constructor. I ran it in its
original
form and it completed successfully. I also modified it to set it's own
default log using my code changes and ran it. I checked to make sure
the engine interface worked correctly with these changes as well.
In both instances, it logged to the location that I expected.
I've included instructions on how to invoke this in the logger.py file.
I've asked Karen and Drew to review. Others are welcome as well.
I'm leaving on vacation, so if you could respond today, I would
appreciate it.
thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
