Hi Ginnie,
I don't think this will address 7066541. You'll need to wrap the
os.mkdir() call around a try, like the following:
import errno
[...]
299 if not os.path.exists(logdir):
try:
os.mkdir(logdir)
except OSError as err:
if err.errno != errno.EEXISTS:
raise
logger.py - 270 - Why not just define this with default_log=DEFAULTLOG,
which would simply lines 292 - 297 to back to:
logdir = os.path.dirname(self.default_log_file)
-ethan
On 08/09/11 12:43, Virginia Wray wrote:
Hi --
Could I get a code review for the following bug:
http://monaco.us.oracle.com/detail.jsf?cr=7033339
Be able to specify logfile name when instantiate InstallLogger
https://cr.opensolaris.org/action/browse/caiman/ginnie/7033339/webrev/
I've tested the changes with the distro constructor. I ran it in its
original
form and it completed successfully. I also modified it to set it's own
default log using my code changes and ran it. I checked to make sure
the engine interface worked correctly with these changes as well.
In both instances, it logged to the location that I expected.
I've included instructions on how to invoke this in the logger.py file.
I've asked Karen and Drew to review. Others are welcome as well.
I'm leaving on vacation, so if you could respond today, I would
appreciate it.
thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
