Hi Mary -
I pep8'd and pylinted the files. I also ran the slim_tests
and didn't see any issues.
ginnie
On 08/ 9/11 02:09 PM, Mary Ding wrote:
Ginnie:
Can you run the slim_install_unit test to make sure they work ? It
will be to make sure the *py files you changed are pep8 clean.
On 08/ 9/11 01:01 PM, Drew Fisher wrote:
Ginnie:
test_logger.py
------------
310-312: commented code?
logger.py
--------
407: change to: if name is not None
Otherwise, this looks good!
-Drew
On 8/9/11 1:43 PM, Virginia Wray wrote:
Hi --
Could I get a code review for the following bug:
http://monaco.us.oracle.com/detail.jsf?cr=7033339
Be able to specify logfile name when instantiate InstallLogger
https://cr.opensolaris.org/action/browse/caiman/ginnie/7033339/webrev/
I've tested the changes with the distro constructor. I ran it in its
original
form and it completed successfully. I also modified it to set it's own
default log using my code changes and ran it. I checked to make sure
the engine interface worked correctly with these changes as well.
In both instances, it logged to the location that I expected.
I've included instructions on how to invoke this in the logger.py file.
I've asked Karen and Drew to review. Others are welcome as well.
I'm leaving on vacation, so if you could respond today, I would
appreciate it.
thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
