Dermot, please see below:
On 08/15/11 07:25 PM, Dermot McCluskey wrote:
Hi William,
One further comments below.
On 08/15/11 18:01, Dermot McCluskey wrote:
Hi William,
Thanks for reviewing. Responses below.
On 08/15/11 17:37, William Schumann wrote:
Dermot,
user_info.py : 284 raise PasswordInvalid(_('User password must be entered.'))
It says 'User' for both user and root, which could lead the user to think that the user password is invalid. Suggest dropping
'User'.
You must be looking at the old version of that file?
I have your exact suggested change in my webrev.
Is there room for all error messages to show up in their entirety (at least for
English...) on an 80-char display?
Yes, they all display fine in English.
However, for fun I tried just now to see what would happen
if they were, say, 20 chars longer. sysconfig terminates
with the following message:
An unhandled expecption occurred.
error: "addstr() returned ERR"
Full traceback data is in the log
This should be fixed by:
7065385 Text installer validation error message causes traceback if >80 chars 7026887 SCI Tool should be prepared to handle longer
usernames
If you can confirm that the error does not occur with this fix, then it's fine
with me.
William
...
I also note the comment in terminalui/base_screen.py:
def validate(self):
'''... The string will be displayed to the
screen (and must be 78 characters or less)
'''
This is obviously not an issue with my changes, but
could become a problem if these, or any other, error
messages end up translated into much longer strings?
I think this could be fixed with a fairly simple truncation
in BaseScreen.validate_loop(). Do you agree?
This seems to fix the problem, but I'm wondering if
there's any reason for not doing this?
If not, should I include this with my fix?
diff -r 35bb460a434e usr/src/lib/terminalui/base_screen.py
--- a/usr/src/lib/terminalui/base_screen.py Mon Aug 15 15:21:08 2011 +0100
+++ b/usr/src/lib/terminalui/base_screen.py Mon Aug 15 18:23:19 2011 +0100
@@ -181,6 +181,8 @@
self.main_win.screen_list.previous_screen()
error_str = unicode(msg)
if error_str:
+ # Ensure display message fits on the screen
+ error_str = error_str[:self._win_size[1] - 1]
self.main_win.error_line.display_err(error_str)
elif next_screen is None:
if self.confirm_quit():
- dermot
- Dermot
William
On 08/15/11 02:51 PM, Dermot McCluskey wrote:
Hi all (esp. Jan, William, Karen),
I'd like 2 or more reviewers for this fix for sysconfig:
http://monaco.sfbay.sun.com/detail.jsf?cr=7056210
restrictions for setting password in sysconfig does not match "passwd" command
Webrev:
https://cr.opensolaris.org/action/browse/caiman/dermot/7056210/
The fix involves calling the validate_password()
function (already in use by GUI Install) from the
Sysconfig Users screen for both the user and root
password fields. The validation code code is slightly
restructured to ensure "higher priority" validation
errors are reported first.
This fix has been tested by running the new
sysconfig code in a VM and confirming that
validation of the root and user password
fields behaves as expected.
Thanks,
- Dermot
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
