Thanks John, Will add those comments
cheers
Matt
On 08/26/11 14:31, John Fischer wrote:
Matt,
Looks good. Please add a comment for the sleep(120) lines. Something to
the effect that the default TTL (Time-To-Live) for the dns records is 120
seconds.
Thanks,
John
On Aug 26, 2011, at 6:09 AM, Matt Keenan wrote:
Hi,
Can I get a review and blessing for fix for :
7050547 ai_sd/aimdns unit tests failing on machine not configured as AI
server
http://monaco.sfbay.sun.com/detail.jsf?cr=7050547
Webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7050547/
Slim install unit tests tend to be run on a build machine which is not
configured as an install server, thus these tests fail. Nose provides a
SkipTest exception which when used will not report the tests themselves as
failed.
For ai_sd if multicast DNS SMF is not available then the tests will fail.
For aimdns if install/server SMF is not available 5 tests will fail.
I also discovered that when a service is removed, it remains advertised for a
default time of 120 seconds, this results in time.sleep(120) calls being
required for tests to be successful.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
