Posted updated webrev, which :
- test_aimdns.py : Moves all checks for install/server SMF into
separate method, and fix type [Darren]
- test_aimdns.py/test_ai_sd.py: Added comment for each 120 second
timeout explaining why [John/Dave]
https://cr.opensolaris.org/action/browse/caiman/mattman/7050547/
Regardless of whether these tests are carried out manually or
automatically these changes are required to ensure they actually run.
If it's decided to make these tests manual then I'd suggest not
splitting them up, but rather moving both in their entirety. [Drew/John]
cheers
Matt
On 08/26/11 15:11, Dave Miner wrote:
On 08/26/11 10:09, John Fischer wrote:
Dave,
That would require a re-architecture of the aimdns' records. Instead
of doing a
default DNSServiceRegister we would need to create a DNS connection,
create
a record and then register it with a shorter TTL value. The default
value which
can not be modified is 120 seconds.
What a silly interface that doesn't provide an easy way to override a
default like that.
Let's capture that in a comment somewhere so that we don't have to ask
the question again.
Dave
Thanks,
John
On Aug 26, 2011, at 6:35 AM, Dave Miner wrote:
On 08/26/11 09:31, John Fischer wrote:
Matt,
Looks good. Please add a comment for the sleep(120) lines. Something to
the effect that the default TTL (Time-To-Live) for the dns records
is 120 seconds.
Is there a way to set these shorter? One of the key attributes of
unit tests is that they run quickly, and we're definitely straying
out of that with all these delays.
Dave
Thanks,
John
On Aug 26, 2011, at 6:09 AM, Matt Keenan wrote:
Hi,
Can I get a review and blessing for fix for :
7050547 ai_sd/aimdns unit tests failing on machine not configured
as AI server
http://monaco.sfbay.sun.com/detail.jsf?cr=7050547
Webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7050547/
Slim install unit tests tend to be run on a build machine which is
not configured as an install server, thus these tests fail. Nose
provides a SkipTest exception which when used will not report the
tests themselves as failed.
For ai_sd if multicast DNS SMF is not available then the tests will
fail.
For aimdns if install/server SMF is not available 5 tests will fail.
I also discovered that when a service is removed, it remains
advertised for a default time of 120 seconds, this results in
time.sleep(120) calls being required for tests to be successful.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
