Thank you for addressing it. Looks fine.
Takeshi
On 2011年09月14日 04:37, Jan Damborsky wrote:
Thank you for review, Takeshi.
I incorporated your suggestion - get_console() is only called
if is_on_console equals True.
updated webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7086621-cr/webrev-cr/
diff webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7086621-cr-diff/webrev-cr-diff/
Jan
On 09/13/11 16:02, Takeshi Asano wrote:
Hi Jan,
LGTM. Thank you for the fixes.
A minor comment is that when is_on_console is False, no need to call
get_console().
Thanks,
Takeshi
On 2011年09月13日 22:14, Jan Damborsky wrote:
Hi,
could I please ask Takeshi and one more pair of eyes to review fix for
following bugs ?
7087759 snv_174 sysconfig's forcing English display does not work
7086621 sysconfig should check if current terminal is console, before
forcing English display
7089508 sample SC profiles configure environment:default instead of
environment:init
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7086621/webrev/
Thank you,
Jan
testing done:
verified that 'sysconfig create-profile' was brought up localized if
* run remotely via ssh
verified that 'sysconfig create-profile' was brought up in English if
* run on physical non-serial (e.g. graphical) console
* run on console of non-global zone (accessed via zlogin -C)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
