Jack,

Looks good.  Please remove the contraction within data_files.py:

    582 # Determine if we're operating with the newer AI DTD,

The other "check" routines within verifyXML.py return a value.
Should the checkMem() return a value to be consistent with the
other ones?

What sort of testing was performed on these fixes?

Thanks,

John


On 09/14/11 08:35 PM, Jack Schwartz wrote:
Hi everyone.

Seeking two reviewers and Dave's approval for the following bug fixes, by Thursday COB to make it into 175 please:

7090295 <http://monaco.us.oracle.com/detail.jsf?cr=7090295> create-manifest with derived manifest script broke 7089832 <http://monaco.us.oracle.com/detail.jsf?cr=7089832> installadm create-profile barfs on range of IP addresses with colons instead of dots.

Webrev:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7090295_1

Bug reports:
http://monaco.us.oracle.com/detail.jsf?cr=7090295
http://monaco.us.oracle.com/detail.jsf?cr=7089832

Note: the first of these is a stopper.
They are bundled together as both make changes to data_files.py.

    Thanks,
    Jack


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to