Hi Darren.
On 09/16/11 05:50 AM, Darren Kenny wrote:
Hi Jack,
Is the last change in the file not also a message change?
D'oh... I'll change it back and file a low-prio bug to fix the message
later.
Filed:
7091490 Last error message in set_AI_schema needs some improvement
Thanks for catching this.
Jack
Should this not be left as it was - I'm not sure the message change is worth it
at this point in time.
Otherwise I'm happy with the changes if they are approved for integration.
Thanks,
Darren.
On 16/09/2011 01:02, Jack Schwartz wrote:
Hi everyone.
Here is an updated webrev for:
7090295<http://monaco.us.oracle.com/detail.jsf?cr=7090295> create-manifest with
derived manifest script broke
7089832<http://monaco.us.oracle.com/detail.jsf?cr=7089832> installadm
create-profile barfs on range of IP addresses with colons instead of dots.
After our meeting I talked with Dave who Okayed changing of 7089832 into a
one-liner that just fixes the traceback, and pushing the rest of the original
fix to change the messages, into a new bug. New bug is:
7091202<http://monaco.sfbay/detail.jsf?cr=7091202> installadm create-profile
needs better messages for invalid criteria
So, 7089832 is back but as a one-liner and verifyXML.py is no longer a part of
the fix.
Oh, and this review also accounts for code review comments too... :)
Version 2:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7090295_2/webrev/
Delta version 2 vs version 1:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7090295_2_1/webrev.2.1.diff/
Dave, please bless.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
