HI John.
On 09/15/11 05:45 AM, John Fischer wrote:
Jack,
Looks good. Please remove the contraction within data_files.py:
582 # Determine if we're operating with the newer AI DTD,
Sure.
The other "check" routines within verifyXML.py return a value.
Should the checkMem() return a value to be consistent with the
other ones?
This is now N/A as the bulk of bug 7089832 has been moved to a new bug
7091202 to be fixed later.
What sort of testing was performed on these fixes?
7089832: installadm create-profile -c ipv4=1:2:3:4 ...
... and watch the command gracefully terminate with the
"Error: Criteria failed validation:..." message
7090295:
Tested by:
- creating a script and adding it with create-manifest.
- verified that a manifest can still be added
- create-manifest -d with a script.
- create-manifest -d with a manifest.
- update-manifest with a script
- update-manifest with a manifest
Thanks,
Jack
Thanks,
John
On 09/14/11 08:35 PM, Jack Schwartz wrote:
Hi everyone.
Seeking two reviewers and Dave's approval for the following bug
fixes, by Thursday COB to make it into 175 please:
7090295 <http://monaco.us.oracle.com/detail.jsf?cr=7090295>
create-manifest with derived manifest script broke 7089832
<http://monaco.us.oracle.com/detail.jsf?cr=7089832> installadm
create-profile barfs on range of IP addresses with colons instead of
dots.
Webrev:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7090295_1
Bug reports:
http://monaco.us.oracle.com/detail.jsf?cr=7090295
http://monaco.us.oracle.com/detail.jsf?cr=7089832
Note: the first of these is a stopper.
They are bundled together as both make changes to data_files.py.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
