Both good suggestions. I made the changes. Thanks, Geoffrey
----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected] Sent: Monday, January 23, 2012 10:39:34 AM GMT -07:00 US/Canada Mountain Subject: Re: [caiman-discuss] Code review request for CPIO transfer fixes Hi Geoffrey -- The copyright on all files needs to be updated to 2012 in all files. cpio.py --------- At line 555 and 646, It is confusing. Can you add a comment describing what is happening. Otherwise, looks good to me. thanks, ginnie On 01/23/12 10:10 AM, Geoffrey Hart wrote: > Happy Monday all! > > Could I please have a code review for: > > 7010088 transfer-cpio should abort when a file to be transferred > is not found > 7092487 cpio transfer errors are not detected or reported > > https://cr.opensolaris.org/action/browse/caiman/ghart/transferFixes/webrev/ > > > > > Testing done for this fix: > > Confirmed that DC and the installers can correctly pass the new > parameter to CPIO. > Confirmed that DC still creates bootable ISOs with the new logic. > Confirmed the installers still complete successfully. > Confirmed that TransferCPIO will fail on missing files (if the input > bool is set). > Confirmed that CPIO copy failures will result in an exception. > Confirmed that new logic will still result in the same files being > copied. Thus the new logic didn't cull any of the expected files. > > > Thanks, > -Geoffrey > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
