Hi Geoffrey,
Everything looks good to me now.
Thanks,
--Karen
On 02/14/12 09:43, Geoffrey Hart wrote:
I have made this update. Updated webrev is:
https://cr.opensolaris.org/action/browse/caiman/ghart/TransferFixesV4/
On 02/10/12 11:28, Karen Tung wrote:
HI Geoffrey,
Thank you for making all the changes. I reviewed the latest webrev,
and I have 1 comment.
cpio.py, lines 303-305: I believe these 2 messages should not be at
the log level debug,
because they won't show up on the DC's simple log and console at the
debug level, and
users won't be made aware of these missing files. Messages at log
level info or above
will show up at DC's simple log and console. I suggest to make these
2 messages
level "warning" so it really catch the user's eye.
Thanks,
--Karen
On 02/10/12 10:17 AM, Geoffrey Hart wrote:
Here is the latest on cr.opensolaris.org:
https://cr.opensolaris.org/action/browse/caiman/ghart/TransferFixesV3/
On 02/10/12 11:03, Mary Ding wrote:
Geoffrey:
You should post this on cr.opensolaris.org.
I also did not see you remove the following from cpio.py per my
code review comments:
Can you remove the following unused import as reported by pylint:
from solaris_install.target.size import Size
On 02/10/12 09:55 AM, Geoffrey Hart wrote:
I have an updated version of the webrev with all the requested
changes applied. Any final comments would be appreciated.
Geoffrey
http://neba/code/transferFixes/webrev/
On 01/23/12 10:10, Geoffrey Hart wrote:
Happy Monday all!
Could I please have a code review for:
7010088 transfer-cpio should abort when a file to be
transferred is not found
7092487 cpio transfer errors are not detected or reported
https://cr.opensolaris.org/action/browse/caiman/ghart/transferFixes/webrev/
Testing done for this fix:
Confirmed that DC and the installers can correctly pass the new
parameter to CPIO.
Confirmed that DC still creates bootable ISOs with the new logic.
Confirmed the installers still complete successfully.
Confirmed that TransferCPIO will fail on missing files (if the
input bool is set).
Confirmed that CPIO copy failures will result in an exception.
Confirmed that new logic will still result in the same files
being copied. Thus the new logic didn't cull any of the expected
files.
Thanks,
-Geoffrey
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
