Yea, go ahead and push it up. I think your local modification is conflicting with the find & replace in `ant version`. We can create an issue and look at it later.
Michael On Mon, Oct 31, 2011 at 2:51 PM, Drew Walters <[email protected]> wrote: > Apparently I lied. Just reran and only updated VERSION file. I apparently > had previously modified Device.java manually prior to knowing of the ant > target. If we don't update the variable in Device.java then > window.device.phonegap will return 1.0. You want me to go ahead and push > and tag my manual changes? > > > On Mon, Oct 31, 2011 at 4:41 PM, Michael Brooks <[email protected]>wrote: > >> Ah great. >> >> If you think it looks okay then go ahead and commit/tag/push! >> >> >> On Mon, Oct 31, 2011 at 2:39 PM, Drew Walters <[email protected]> wrote: >> >>> Thanks Michael, FYI, I ran the ant script locally and it looked ok. It >>> updated VERSION and Device.java which is what I would expect. I did not >>> push the changes or tag since you are going to do it. >>> >>> >>> On Mon, Oct 31, 2011 at 4:37 PM, Michael Brooks >>> <[email protected]>wrote: >>> >>>> Thanks a lot Drew, >>>> >>>> I'll tag this release (and accept blame if I mess it up again). I just >>>> want to make sure that the the ANT script does the job correctly. >>>> >>>> Michael >>>> >>>> On Mon, Oct 31, 2011 at 2:35 PM, Drew Walters <[email protected]>wrote: >>>> >>>>> Excellent, thanks Michael. I hadn't noticed that in the README >>>>> before. I've pushed all the changes I need to make so BlackBerry is ready >>>>> to be tagged. >>>>> >>>>> >>>>> On Mon, Oct 31, 2011 at 4:30 PM, Michael Brooks < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Drew, >>>>>> >>>>>> This was a mistake on my side. We were rushing the release and I >>>>>> didn't update phonegap-blackberry-webworks properly. >>>>>> >>>>>> I've documented how to do a proper release in the README and >>>>>> automated it with an ANT command. >>>>>> >>>>>> Michael >>>>>> >>>>>> On Monday, 31 October, 2011 at 2:25 PM, Drew Walters wrote: >>>>>> >>>>>> I noticed the previous BlackBerry move from 1.0.0 to 1.1.0 only >>>>>> updated the VERSION file: >>>>>> >>>>>> >>>>>> https://github.com/callback/callback-blackberry/commit/8caf6193b2b4ed9b59e6bce6eca79777e8582d21 >>>>>> >>>>>> whereas previously we were updating Device.java, library.xml and >>>>>> config.xml: >>>>>> >>>>>> >>>>>> https://github.com/phonegap/phonegap-blackberry-webworks/commit/f42a61c2d1884b45fe00eb754e2657b20b3ed272 >>>>>> >>>>>> Was this intentional or were some changes missed? I could understand >>>>>> not updating library.xml and config.xml because it minimizes impact to >>>>>> application developers but Device.java should be updated with proper >>>>>> version. >>>>>> >>>>>> Thoughts? I can make changes if responses are quick otherwise I will >>>>>> be passing out candy :-) >>>>>> >>>>>> On Mon, Oct 31, 2011 at 3:49 PM, Steve <[email protected]> wrote: >>>>>> >>>>>> Hey guys, >>>>>> >>>>>> If everyone is ready, I was hoping you guys could tag your repos >>>>>> 1.2.0. I can package it up and ship it today. >>>>>> >>>>>> Cheers, >>>>>> -Steve >>>>>> >>>>>> On Tue, Oct 25, 2011 at 3:47 PM, Brian LeRoux <[email protected]> wrote: >>>>>> >>>>>> > I think Brian is referring to a phonegap release from Nitobi, not a >>>>>> Callback release from the Incubator. Sort of "flush the queue" kind of >>>>>> stuff before starting to work 100% within the ASF. Is that the case? >>>>>> >>>>>> precisely so >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> -Steve Gill >>>>>> Nitobi Software >>>>>> www.nitobi.com >>>>>> http://twitter.com/#!/stevesgill >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >> >
