kossebau added a comment. In https://phabricator.kde.org/D183#4272, @abrahams wrote:
> Things are not as simple as renaming krita_export.h to kritaimage_export.h. > The former was actually a collection of different symbol definitions. The > intermediate change you're proposing would mean you will need to create the > following new files: (don't quote me on the names) kritaimage_export.h, > kritaui_export.h, kritasketch_export.h, paintop_export.h, > kritabrush_export.h. The subsequent commit would then delete these files. > It seems like a lot of work for a minor bit of history sanitizing. Well, the include lines have to be changed anyway (but right, this patch has the work done already). Adding a few export headers temporarily seems not such a problem to me. This is not about history sanitizing. It is about getting a smaller diff between 2.9 and frameworks. Remember that some people are still working on features in Krita in the 2.9 branch (or branches based on that). And when their commits are merged to frameworks (or cherry-picked in the future), these different include lines have chances to result in merge conflicts, which can be painful to resolve. Oh well. Not being a Krita dev doing development in 2.9, I perhaps should care less about that :) I hinted to this possible problem, so I am out now on this point :) REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: abrahams, dkazakov, staniek, rempt, kossebau Cc: Calligra-Devel-list, staniek, kossebau _______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
