abrahams added a comment. In https://phabricator.kde.org/D183#4279, @kossebau wrote:
> In https://phabricator.kde.org/D183#4278, @abrahams wrote: > > > OK, I understand now. The problem with doing it personally is that > > maintaining separate 2.9 and 3.0 builds on Windows is a huge challenge, and > > since installing Windows 10 I have not bothered with 2.9 anymore. It's not > > simply adding the export headers, but the many hours of setting up a new > > build environment and testing to make sure it's all working properly that > > makes me averse to doing the split myself. > > > I see. So given I insisted on this so much, would you be okay with me doing > the according change to 2.9 (by taking the diff to all the krita files and > creating the respecitve expoort headers), so I would back the noise I made > myself? :) Would do tonight. and should arrive in frameworks on Friday. Yes, > means you mght need to adapt your patch once more (hopefully though the > includes lines would resolve without issues), but this might still in the end > be easier because the affected things are known and thus easier to solve. Absolutely, I have no problem rebasing the patch against Frameworks updates. I just want to avoid messing around with 2.9. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D183 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: abrahams, dkazakov, staniek, rempt, kossebau Cc: Calligra-Devel-list, staniek, kossebau _______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
