staniek added a comment.
Like skipping the changes for kexi/, I propose to split the final patch: skip
the proper changes in krita/ and in whatever dirs keeps krita touch for
calligra/2.9 (pigment, some libs/?). And then commit the non-kexi/non-krita
things.
Regarding the exporting extra symbols for testing. I see that builds with
testing enabled are not for general distribution. They contain mock code, at
least for Kexi they can do. They contain double checking that's also not
needed/efficient. Then may depend on the Debug build type. So for me it's
perfectly OK to export them in these builds.
How to do that?
e.g. in MYLIB lib's source dir:
if(BUILD_TESTING)
add_definitions(-DMYLIB_TEST_EXPORT=MYLIB_EXPORT)
else()
add_definitions(-DMYLIB_TEST_EXPORT=)
endif()
Then use MYLIB_TEST_EXPORT to export the extra symbols.
It's not a lot of code, and well... not every lib adds extra exports.
REPOSITORY
rCALLIGRA Calligra
REVISION DETAIL
https://phabricator.kde.org/D183
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: abrahams, dkazakov, staniek, rempt, kossebau
Cc: Calligra-Devel-list, staniek, kossebau
_______________________________________________
calligra-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/calligra-devel
