Sumedha, I agree totally. However, no one is born with the art of coding. Even artists learn from other artists and gain from years of experience.
When I was a young programmer (a long time ago now ;-)) I was lucky to be sitting next to and working closely with an incredibly good programmer. I learnt a LOT from him. I may have learnt those things by myself too but not as fast! A lot of folks have not had the chance to work on large systems where code has to live for a long time. The purpose of code reviews is to help people learn and understand and internalize best practices that will make it possible to achieve high quality results while still having fun being a code artist :). Lets try this for a while .. if it doesn't work we'll iterate, like with everything else! Sanjiva. On Wed, Sep 29, 2010 at 9:54 PM, Sumedha Rubasinghe <[email protected]>wrote: > > > On Wed, Sep 29, 2010 at 12:03 PM, Sanjiva Weerawarana <[email protected]>wrote: > >> Azeez, can I also suggest that every 2 months you mix the people up again? >> Code reviews and best practices are best learnt from multiple people. That >> way everyone gets input from multiple leaders. >> >> I would also like to urge the leaders to attend at least one of the other >> code reviews each week! Again I suggest rotating which one each person >> attends (no need to schedule that - each of these people should pick one and >> go to it). >> > > Geese.....this is getting more complicated than writing code itself... > :-)... > Writing code is fun... and this whole process would have been much more > simpler if every SE take pride of their work, learn best practices > themselves & keep on improving everyday... But.. I guess we are far from > this idealistic situ... > > Like a drawing of an artist, every SE should realize code they write is one > of the primary(if not THE) external showcases of their work. If one doesn't > consider improving this external showcase.. shame one you... > > Just my 2 cents... > > /sumedha > > > >> >> Thanks, >> >> Sanjiva. >> >> On Wed, Sep 29, 2010 at 11:58 AM, Afkham Azeez <[email protected]> wrote: >> >>> Hi team, >>> In order to carry out code review sessions in a more effective manner, we >>> will be having multiple code review sessions per week with smaller groups. >>> The following people will be leading the code review sessions: >>> >>> 1. Ruwan >>> 2. Supun >>> 3. Milinda >>> 4. Hiranya >>> 5. AmilaS >>> 6. AmilaJ >>> 7. Senaka >>> >>> Today we had a meeting related to this. The notes from this session are >>> given below: >>> >>> 1. Engineering team members have been divided into groups of 15. See [1] >>> 2. Groups will comprise folks from different teams, and will be a mix of >>> people with different experience levels. >>> 3. 5 reviews per week in general. We can have multiple sessions per day. >>> 4. We need to have descriptive code review notes, and when these issues >>> are addressed, a summary of what was done should be provided. >>> 5. We plan to evaluate the code review tool Crucible - >>> http://crucible.wso2.com during the first few sessions >>> 6. Code reviews need to be prescheduled and the relevant group of people >>> should be informed of the sections in advance, so that they can provide >>> feedback before the session. >>> >>> >>> Reference >>> 1. >>> https://spreadsheets0.google.com/a/wso2.com/ccc?key=tE8m7UvpY-DkW9xM596-e3Q&hl=en#gid=0 >>> >>> >>> >>> <https://spreadsheets0.google.com/a/wso2.com/ccc?key=tE8m7UvpY-DkW9xM596-e3Q&hl=en#gid=0>Thoughts >>> & suggestions are welcome. >>> >>> Thanks >>> -- >>> *Afkham Azeez* >>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com >>> , >>> * >>> * >>> *Member; Apache Software Foundation; >>> **http://www.apache.org/*<http://www.apache.org/> >>> * >>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>> * >>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>> * >>> * >>> *Lean . Enterprise . Middleware* >>> >>> >>> >>> >>> _______________________________________________ >>> Carbon-dev mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> Sanjiva Weerawarana, Ph.D. >> Founder, Chairman & CEO; WSO2, Inc.; http://wso2.com/ >> email: [email protected]; phone: +1 408 754 7388 x51726; cell: +94 77 787 >> 6880 | +1 650 265 8311 >> blog: http://sanjiva.weerawarana.org/ >> >> Lean . Enterprise . Middleware >> >> _______________________________________________ >> Carbon-dev mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Sanjiva Weerawarana, Ph.D. Founder, Chairman & CEO; WSO2, Inc.; http://wso2.com/ email: [email protected]; phone: +1 408 754 7388 x51726; cell: +94 77 787 6880 | +1 650 265 8311 blog: http://sanjiva.weerawarana.org/ Lean . Enterprise . Middleware
_______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
