Afkham Azeez wrote: > During a discussion with AmilaS last evening, Amila came up with the > excellent suggestion of coming up with some design diagrams & basic > design documentation related to the components being reviewed. During > each review session, the session lead starts off by explaining the > high level design of the components or area of the code being > reviewed. People have been presenting slides or using the whiteboard > to explain the design. It will be worthwhile in the long run, if these > resources are committed to SVN. This will make it easy for a new > person who takes over the code to understand the component? What do > you guys think? +1. Will be great if session participants can get this design document before session starts. Then everyone can go through the document and we'll be able to save more time for code review.
Thanks AmilaJ > > Azeez > > > > On Wed, Sep 29, 2010 at 11:58 AM, Afkham Azeez <[email protected] > <mailto:[email protected]>> wrote: > > Hi team, > In order to carry out code review sessions in a more effective > manner, we will be having multiple code review sessions per week > with smaller groups. The following people will be leading the code > review sessions: > > 1. Ruwan > 2. Supun > 3. Milinda > 4. Hiranya > 5. AmilaS > 6. AmilaJ > 7. Senaka > > Today we had a meeting related to this. The notes from this > session are given below: > > 1. Engineering team members have been divided into groups of 15. > See [1] > 2. Groups will comprise folks from different teams, and will be a > mix of people with different experience levels. > 3. 5 reviews per week in general. We can have multiple sessions > per day. > 4. We need to have descriptive code review notes, and when these > issues are addressed, a summary of what was done should be provided. > 5. We plan to evaluate the code review tool Crucible - > http://crucible.wso2.com during the first few sessions > 6. Code reviews need to be prescheduled and the relevant group of > people should be informed of the sections in advance, so that they > can provide feedback before the session. > > > Reference > 1. > https://spreadsheets0.google.com/a/wso2.com/ccc?key=tE8m7UvpY-DkW9xM596-e3Q&hl=en#gid=0 > > <https://spreadsheets0.google.com/a/wso2.com/ccc?key=tE8m7UvpY-DkW9xM596-e3Q&hl=en#gid=0> > > > Thoughts & suggestions are welcome. > > Thanks > -- > *Afkham Azeez* > Senior Software Architect & Senior Manager; WSO2, Inc.; > http://wso2.com, > / > / > /Member; Apache Software Foundation; //http://www.apache.org/// > email: //[email protected]/ <mailto:[email protected]>/ cell: +94 77 3320919 > blog: //http://blog.afkham.org// > twitter: //http://twitter.com/afkham_azeez// > linked-in: //http://lk.linkedin.com/in/afkhamazeez/ > / > / > /Lean . Enterprise . Middleware/ > > > > > > > -- > *Afkham Azeez* > Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, > / > / > /Member; Apache Software Foundation; //http://www.apache.org/// > email: //[email protected]/ <mailto:[email protected]>/ cell: +94 77 3320919 > blog: //http://blog.afkham.org// > twitter: //http://twitter.com/afkham_azeez// > linked-in: //http://lk.linkedin.com/in/afkhamazeez/ > / > / > /Lean . Enterprise . Middleware/ > > ------------------------------------------------------------------------ > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > _______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
