I created this pull request

https://github.com/Jasig/cas/pull/13/files

through the GitHub web-based UI just now, and *it* mangled a bunch of lines in that messages_fr.properties file.

So, why is this so hard? Are other projects experiencing this much pain trying to accept a single contributed message to a non-English message file?

This isn't just a whitespace issue.  This is a file encoding issue?

Andrew


On 11/29/2011 2:31 PM, Marvin Addison wrote:
Only a few of those files had a lot of lines changed.  I'd guess that they
had a different EOL than most, and you made them consistent.
I do hope we'll take on the task at some point to conform whitespace
across the CAS codebase.  While it may well be a holywar of tab vs
space and CRLF versus LF, I think the consistency in the end will be
worth the effort and will reduce the likelihood of issues like this.

M



--
You are currently subscribed to cas-dev@lists.jasig.org as: 
arch...@mail-archive.com
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-dev

Reply via email to