On Tue, Jan 12, 2010 at 8:22 PM, Roelof Blom <[email protected]> wrote:

> The project.version property was originally for versioning the entire
> project, and assembly.version for versioning a specific project assembly.


I'm not sure I follow exactly. Are you saying we should get rid of this:

    <property overwrite="false" name="assembly.version"
value="${project.major}.${project.minor}.${project.build}.0" />
    <property overwrite="false" name="assembly.version.informational"
value="${assembly.major}.${assembly.minor}.${assembly.build}.${svn.revision}"
/>

    <property name="assembly.major"
value="${version::get-major(version::parse(assembly.version))}"
dynamic="true" />
    <property name="assembly.minor"
value="${version::get-minor(version::parse(assembly.version))}"
dynamic="true" />
    <property name="assembly.build"
value="${version::get-build(version::parse(assembly.version))}"
dynamic="true" />
    <property name="assembly.revision"
value="${version::get-revision(version::parse(assembly.version))}"
dynamic="true" />


> With the schism we should probably drop assembly.version
>
I'm not sure what "schism" means but we don't manually maintain both, we
only set project.version. I set the project version to 0.0.0.0 in the common
build file because Krzysztof changed it from 1.1 to 1.2 because the logging
services build script didn't have the line to change the project version. I
don't think we should be using the common file to control any specific
project.

Did I misunderstand you?


>
> On Tue, Jan 12, 2010 at 11:19 AM, <[email protected]> wrote:
>
>>   *6637* <http://fisheye2.atlassian.com/changelog/castleproject?cs=6637>
>> *jonathon.rossi* Tue, 12 January 2010, 11:18:15 +0100
>> ------------------------------
>> Default the project version to 0.0.0.0 so that each project needs to set
>> its own version number.
>> ------------------------------
>>   
>> buildscripts/common.xml<http://fisheye2.atlassian.com/browse/castleproject/buildscripts/common.xml>
>> 6637<http://fisheye2.atlassian.com/browse/castleproject/buildscripts/common.xml?r=6637>
>> (+1-1) 
>> diffs<http://fisheye2.atlassian.com/browse/castleproject/buildscripts/common.xml?r1=6626&r2=6637>
>>
>> show watches <http://fisheye2.atlassian.com/profile/showWatches.do>
>> ------------------------------
>>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Castle Project Development List" group.
> To post to this group, send email to [email protected]
> .
> To unsubscribe from this group, send email to
> [email protected]<castle-project-devel%[email protected]>
> .
> For more options, visit this group at
> http://groups.google.com/group/castle-project-devel?hl=en.
>
>


-- 
Jono
--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en.

Reply via email to