Check DP for instance: - default.build has <property name="project.version" value="2.2.0.0" /> - Castle.DynamicProxy.build has <property name="assembly.version" value="2.1.0.0" />
Confusing (and wrong). On Tue, Jan 12, 2010 at 12:07 PM, Roelof Blom <[email protected]> wrote: > All the assembly.version instances should be removed and replaced by > project.version in the top-level default.build for the project. > > On Tue, Jan 12, 2010 at 12:05 PM, John Simons > <[email protected]>wrote: > >> This will be a breaking change, so if any project "default.build" >> files do not have "<property name="assembly.version" value="X.Y.Z.W" / >> >" defined (which btw are a lot of them, specially test projects), the >> nant script will fail. >> Is that ok? >> >> >> On Jan 12, 9:59 pm, Jonathon Rossi <[email protected]> wrote: >> > Oh I get Roelof now. >> > >> > Inside Castle.Core.dll's build script it has this: >> > <property name="assembly.version" value="1.2.0.0" /> >> > >> > When we already set this in the script for the project. Yes, I think we >> > should remove the assembly.version variable. >> > >> > On Tue, Jan 12, 2010 at 8:55 PM, John Simons < >> [email protected]>wrote: >> > >> > >> > >> > > To set the version of an individual assembly, all you need to do is: >> > > - Open the default.build file for the project you want to set >> > > - And add "<property name="assembly.version" value="x.y.z.w" />" >> > > inside the "init" target, eg: >> > > <target name="init" depends="common.init"> >> > > <property name="assembly.version" value="3.0.1.0" /> >> > > <assemblyfileset id="project.references" >> > > basedir="${build.dir}"> >> > > </assemblyfileset> >> > > </target> >> > >> > > Cheers >> > > John >> > >> > > On Jan 12, 9:39 pm, Jonathon Rossi <[email protected]> wrote: >> > > > On Tue, Jan 12, 2010 at 8:22 PM, Roelof Blom <[email protected] >> > >> > > wrote: >> > > > > The project.version property was originally for versioning the >> entire >> > > > > project, and assembly.version for versioning a specific project >> > > assembly. >> > >> > > > I'm not sure I follow exactly. Are you saying we should get rid of >> this: >> > >> > > > <property overwrite="false" name="assembly.version" >> > > > value="${project.major}.${project.minor}.${project.build}.0" /> >> > > > <property overwrite="false" >> name="assembly.version.informational" >> > >> > > >> value="${assembly.major}.${assembly.minor}.${assembly.build}.${svn.revision}" >> > > > /> >> > >> > > > <property name="assembly.major" >> > > > value="${version::get-major(version::parse(assembly.version))}" >> > > > dynamic="true" /> >> > > > <property name="assembly.minor" >> > > > value="${version::get-minor(version::parse(assembly.version))}" >> > > > dynamic="true" /> >> > > > <property name="assembly.build" >> > > > value="${version::get-build(version::parse(assembly.version))}" >> > > > dynamic="true" /> >> > > > <property name="assembly.revision" >> > > > value="${version::get-revision(version::parse(assembly.version))}" >> > > > dynamic="true" /> >> > >> > > > > With the schism we should probably drop assembly.version >> > >> > > > I'm not sure what "schism" means but we don't manually maintain >> both, we >> > > > only set project.version. I set the project version to 0.0.0.0 in >> the >> > > common >> > > > build file because Krzysztof changed it from 1.1 to 1.2 because the >> > > logging >> > > > services build script didn't have the line to change the project >> version. >> > > I >> > > > don't think we should be using the common file to control any >> specific >> > > > project. >> > >> > > > Did I misunderstand you? >> > >> > > > > On Tue, Jan 12, 2010 at 11:19 AM, <[email protected]> >> wrote: >> > >> > > > >> *6637* < >> > >http://fisheye2.atlassian.com/changelog/castleproject?cs=6637> >> > > > >> *jonathon.rossi* Tue, 12 January 2010, 11:18:15 +0100 >> > > > >> ------------------------------ >> > > > >> Default the project version to 0.0.0.0 so that each project needs >> to >> > > set >> > > > >> its own version number. >> > > > >> ------------------------------ >> > > > >> buildscripts/common.xml< >> > > >> http://fisheye2.atlassian.com/browse/castleproject/buildscripts/commo...> >> > > > >> 6637< >> > > >> http://fisheye2.atlassian.com/browse/castleproject/buildscripts/commo...> >> > > > >> (+1-1) diffs< >> > > >> http://fisheye2.atlassian.com/browse/castleproject/buildscripts/commo...> >> > >> > > > >> show watches < >> http://fisheye2.atlassian.com/profile/showWatches.do> >> > > > >> ------------------------------ >> > >> > > > > -- >> > > > > You received this message because you are subscribed to the Google >> > > Groups >> > > > > "Castle Project Development List" group. >> > > > > To post to this group, send email to >> > > [email protected] >> > > > > . >> > > > > To unsubscribe from this group, send email to >> > > > > [email protected]<castle-project-devel%[email protected]> >> <castle-project-devel%[email protected]<castle-project-devel%[email protected]> >> > >> > > <castle-project-devel%[email protected]<castle-project-devel%[email protected]> >> <castle-project-devel%[email protected]<castle-project-devel%[email protected]> >> > >> > >> > > > > . >> > > > > For more options, visit this group at >> > > > >http://groups.google.com/group/castle-project-devel?hl=en. >> > >> > > > -- >> > > > Jono >> > >> > > -- >> > > You received this message because you are subscribed to the Google >> Groups >> > > "Castle Project Development List" group. >> > > To post to this group, send email to >> [email protected] >> > > . >> > > To unsubscribe from this group, send email to >> > > [email protected]<castle-project-devel%[email protected]> >> <castle-project-devel%[email protected]<castle-project-devel%[email protected]> >> > >> > > . >> > > For more options, visit this group at >> > >http://groups.google.com/group/castle-project-devel?hl=en. >> > >> > -- >> > Jono >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Castle Project Development List" group. >> To post to this group, send email to >> [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<castle-project-devel%[email protected]> >> . >> >> For more options, visit this group at >> http://groups.google.com/group/castle-project-devel?hl=en. >> >> >> >> >--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en.
