Aren't we mixing up things here? If someone wants a readonly nhibernate session, why he would be achieving that set a tx = readonly?
It hasa couple of inconsistencies: - it assumes that the transaction is only been using the open and close the nhibernate session. If true, it should has a orthogonal and decoupled way to doing it - the transaction doesn't a exposes a clearly read-only contract. so other resources probably will be commited or rolledback. So, we can scenarios like: "yeahh, it's a readonly tx, but only for nhibernate. the other resources (like msmq) doesn't support this concept so they are committed anyways". Cheers, Henry Conceição On Wed, Oct 6, 2010 at 2:49 PM, hammett <[email protected]> wrote: > I'm ok with these changes, with this exception: > > http://github.com/castleproject/Castle.Facilities.NHibernateIntegration/pull/1#L10R97 > > Shouldn't be in the ambient condition. > > On Wed, Oct 6, 2010 at 2:01 AM, Jordan Muscott > <[email protected]> wrote: >> http://github.com/castleproject/Castle.Services.Transaction/pull/1 >> http://github.com/castleproject/Castle.Facilities.AutomaticTransactionManagement/pull/1 >> http://github.com/castleproject/Castle.Facilities.NHibernateIntegration/pull/1 >> >> Jordan. >> >> >> On Oct 5, 10:55 pm, hammett <[email protected]> wrote: >>> Where is the link for the pull request? >>> >>> On Fri, Aug 13, 2010 at 2:00 AM, Jordan Muscott >>> >>> <[email protected]> wrote: >>> > Thats ok. It would be great if someone could though :) >>> >>> -- >>> Cheers, >>> hammetthttp://hammett.castleproject.org/ >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Castle Project Development List" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/castle-project-devel?hl=en. >> >> > > > > -- > Cheers, > hammett > http://hammett.castleproject.org/ > > -- > You received this message because you are subscribed to the Google Groups > "Castle Project Development List" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/castle-project-devel?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en.
