On 2010-06-25 11:01, Joel Rosdahl wrote: > I haven't looked at the others in detail yet. I'll get back to you when I > have more time.
"Introduce and use x_fmmap()": Nice cleanup in general. A comment with some documention of x_fmmap's semantics and parameters would be nice. And maybe remove trailing space from last argument when calling x_fmmap and add a space in the format strings in x_fmmap instead? "Don't dup fd for zlib, and gzclose() gzdopen()d file": The gzclose() is fine, but I'm not sure about the removal of dup() since that will make copy_fd close fd_in because gzclose() will close it. "Don't overwrite a file that is currently opened": I agree that it ideally should be done only on Windows, but I think it's OK since it's a rare case. Applied. "Close manifest files before moving them": You can remove "if (f1) { gzclose(f1) }" in "out:". Also, close(fd) shouldn't be needed after gzclose(f) when f was created with gzdopen(fd, ...). "Win32 support": Haven't looked at this one yet. And I'm going on vacation to Greece for one week tomorrow, so I'll continue when I'm home again. -- Joel _______________________________________________ ccache mailing list ccache@lists.samba.org https://lists.samba.org/mailman/listinfo/ccache