On Mon, Dec 14, 2015 at 10:52 PM, Martin Millnert <mar...@millnert.se> wrote: > On Mon, 2015-12-14 at 14:17 +0100, Radoslaw Zarzynski wrote: >> Hello Folks, >> >> I would like to publish a proposal regarding improvements to Ceph >> data-at-rest encryption mechanism. Adam Kupczyk and I worked >> on that in last weeks. >> >> Initially we considered several architectural approaches and made >> several iterations of discussions with Intel storage group. The proposal >> is condensed description of the solution we see as the most promising >> one. >> >> We are open to any comments and questions. >> >> Regards, >> Adam Kupczyk >> Radoslaw Zarzynski >> >> >> ======================= >> Summary >> ======================= >> >> Data at-rest encryption is mechanism for protecting data center >> operator from revealing content of physical carriers. >> >> Ceph already implements a form of at rest encryption. It is performed >> through dm-crypt as intermediary layer between OSD and its physical >> storage. The proposed at rest encryption mechanism will be orthogonal >> and, in some ways, superior to already existing solution. >> >> ======================= >> Owners >> ======================= >> >> * Radoslaw Zarzynski (Mirantis) >> * Adam Kupczyk (Mirantis) >> >> ======================= >> Interested Parties >> ======================= >> >> If you are interested in contributing to this blueprint, or want to be >> a "speaker" during the Summit session, list your name here. >> >> Name (Affiliation) >> Name (Affiliation) >> Name >> >> ======================= >> Current Status >> ======================= >> >> Current data at rest encryption is achieved through dm-crypt placed >> under OSD’s filestore. This solution is a generic one and cannot >> leverage Ceph-specific characteristics. The best example is that >> encryption is done multiple times - one time for each replica. Another >> issue is lack of granularity - either OSD encrypts nothing, or OSD >> encrypts everything (with dm-crypt on). > > All or nothing is some times a desired function of encryption. > "In-betweens" are tricky. > > Additionally, dm-crypt is AFAICT fairly performant since at least > there's no need to context switch per crypto-op, since it sits in the dm > IO path within kernel.
Hello Martin, I cannot agree about dm-crypt performance in comparison to the OSD solution. Each BIO handled by dm-crypt must go through at least one kernel workqueue (kcryptd) . Some of them have to pass additional one (kcryptd_io) . Those wqueues are served by dedicated set of kthreads, so context switches are present here. Moreover, the whole BIO is split into small, 512 bytes long chunks before passing to ablkcipher . IMO that's far less than ideal. In the case of application-layer encryption you would operate much closer to the data. You may encrypt in much larger chunks. Costs of context switches and op setup phase (important for hw accelerators) would be negligible providing much better performance. Leveraging some Ceph-specific characteristics (encrypting only selected pools; constant complexity according to replica count) multiplies gain even further. Regards, Radoslaw  http://lxr.free-electrons.com/source/drivers/md/dm-crypt.c?v=3.19#L1350  http://lxr.free-electrons.com/source/drivers/md/dm-crypt.c?v=3.19#L1355  http://lxr.free-electrons.com/source/drivers/md/dm-crypt.c?v=3.19#L864 > > These two points are not necessarily a critique of your proposal. > >> Cryptographic keys are stored on filesystem of storage node that hosts >> OSDs. Changing them require redeploying the OSDs. > > Not very familiar with what deployment technique of dm-crypt you refer > to (don't use ceph-deploy personally). But the LUKS FDE suite does allow > for separating encryption key from activation key (or whatever it is > called). > >> The best way to address those issues seems to be introducing >> encryption into Ceph OSD. >> >> ======================= >> Detailed Description >> ======================= >> >> In addition to the currently available solution, Ceph OSD would >> accommodate encryption component placed in the replication mechanisms. >> >> Data incoming from Ceph clients would be encrypted by primary OSD. It >> would replicate ciphertext to non-primary members of an acting set. >> Data sent to Ceph client would be decrypted by OSD handling read >> operation. This allows to: >> * perform only one encryption per write, >> * achieve per-pool key granulation for both key and encryption itself. > > I.e. the primary OSD's key for the PG in question, would be the one used > for all replicas of the data, per acting set. I.e. granularity of > actually one key per acting set, controlled by primary OSD? > >> Unfortunately, having always and everywhere the same key for a given >> pool is unacceptable - it would make cluster migration and key change >> extremely burdensome process. To address those issues crypto key >> versioning would be introduced. All RADOS objects inside single >> placement group stored on a given OSD would use the same crypto key >> version. > > This seems to add key versioning on the primary OSD. > >> The same PG on other replica may use different version of the >> same, per pool-granulated key. > > Attempt to rewrite to see if I parsed correctly: Within a PG's acting > set, a non-primary OSD can use another version of the per-pool key. > That seems fair, to support asynchronous key roll forward/backward. > >> In typical case ciphertext data transferred from OSD to OSD can be >> used without change. This is when both OSDs have the same crypto key >> version for given placement group. In rare cases when crypto keys are >> different (key change or transition period) receiving OSD will recrypt >> with local key versions. > > Doesn't this presume the receiving OSD always has more up to date set of > keys than the sending OSD? > What if sending OSD has a newer key than the receiving OSD? > >> For compression to be effective it must be done before encryption. Due >> to that encryption may be applied differently for replication pools >> and EC pools. Replicated pools do not implement compression; for those >> pools encryption is applied right after data enters OSD. For EC pools >> encryption is applied after compressing. When compression will be >> implemented for replicated pools, it must be placed before encryption. >> >> Ceph currently has thin abstraction layer over block ciphers >> (CryptoHandler, CryptoKeyHandler). We want to extend this API to >> introduce initialization vectors, chaining modes and asynchronous >> operations. Implementation of this API may be based on AF_ALG kernel >> interface. This assures the ability to use hardware accelerations >> already implemented in Linux kernel. Moreover, due to working on >> bigger chunks (dm-crypt operates on 512 byte long sectors) the raw >> encryption performance may be even higher. > > >> The encryption process must not impede random reads and random writes >> to RADOS objects. > > That's a brave statement. :-) > >> Solution for this is to create encryption/decryption >> process that will be applicable for arbitrary data range. This can be >> done most easily by applying chaining mode that doesn’t impose >> dependencies between subsequent data chunks. Good candidates are >> CTR and XTS. >> >> Encryption-related metadata would be stored in extended attributes. >> >> In order to coordinate encryption across acting set, all replicas will >> share information about crypto key versions they use. Real >> cryptographic keys never be stored permanently by Ceph OSD. Instead, >> it would be gathered from monitors. Key management improvements will >> be addressed in separate task based on dedicated proposal . > > Key management is indeed the Achilles heel of any cluster solution like > this, and depending on requirements sooner or later descends into some > sort of TPM or similar, I guess. I.e. "to trust a computer someone else > may have arbitrary physical access to." > > /M > >>  >> https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Counter_.28CTR.29 >> >>  >> https://en.wikipedia.org/wiki/Disk_encryption_theory#XEX-based_tweaked-codebook_mode_with_ciphertext_stealing_.28XTS.29 >> >>  >> http://tracker.ceph.com/projects/ceph/wiki/Osd_-_simple_ceph-mon_dm-crypt_key_management >> >> ======================= >> Work items >> ======================= >> >> Coding tasks >> * Extended Crypto API (CryptoHandler, CryptoKeyHandler). >> * Encryption for replicated pools. >> * Encryption for EC pools. >> * Key management. >> >> Build / release tasks >> * Unit tests for extended Crypto API. >> * Functional tests for encrypted replicated pools. >> * Functional tests for encrypted EC pools. >> >> Documentation tasks >> * Document extended Crypto API. >> * Document migration procedures. >> * Document crypto key creation and versioning. >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html