Hello,

I'm back from leave. This is where I think we are with this discussion.

  * "Rules for correcting errors in CF documents" **[1]** and "Rules for CF 
Conventions Changes" **[2]** look good to me and have no outstanding comments.

  * "Contributing to the NetCDF-CF conventions" **[3]** is also looking good, 
but I wonder if we need to make note in this document of the issue that @erget 
raised: which branch should pull requests be created for?

    I favour creating a branch for the next version (e.g. `1.8`) and specifying 
that pull requests be made to this branch. This branch would be created as a 
copy of the previous version (1.7) when that is released. An advantage of this 
over using `master` is that accepted issues can be merged into the branch prior 
to release, and so be picked up by PRs for other, newer issues. I don't have 
particularly strong views on this, though - on which branch nor whether this 
should be in the CONTRIBUTING.md document.

**[1]** 
https://github.com/cf-convention/cf-convention.github.io/pull/62/commits/e6f7747c8b94952651c567c9ffead9f74131080b?short_path=8f8a0b0#diff-8f8a0b09fa5f199438dd9e7557ce36db

**[2]** 
https://github.com/cf-convention/cf-convention.github.io/pull/62/files?short_path=91508a7#diff-91508a78c1f574c8c31da226cf3e7622

**[3]** 
https://github.com/cf-convention/cf-conventions/pull/137/files?short_path=8cc7b2b#diff-8cc7b2b0d78dd2501610391c086a8516

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/130#issuecomment-412887316

Reply via email to