Dear Jonathan, 

Actually, this text will end up in a "CONTRIBUTING.md" in this repository. It 
may also end up on the main web site. [This pull request 
](https://github.com/cf-convention/cf-convention.github.io/pull/62) likely 
needs some attention in light of the conversation here.

- Changed which to that.
- Yes, I think we should expect issues to be closed by practically all pull 
requests. I've modified the text.
- Yes, we should insist that those labels be used for **contributions.** Note 
that we may have labels for questions or other kinds of "issues".
- added: "as these changes do not appear in the convention history."
- Fixed type.
- Added "Note that their is a rendered "rich-diff" view of a pull request that 
can be helpful for review of large contributions."

I will get these changes checked in soon.

Best, 

- Dave

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/cf-convention/cf-conventions/issues/130#issuecomment-407176332

Reply via email to