On Wed, Jul 9, 2014 at 12:00 PM, Nico Weber <[email protected]> wrote:
> On Wed, Jul 9, 2014 at 8:53 AM, Ehsan Akhgari <[email protected]> > wrote: > >> That's OK, the main intention behind this patch is to unbreak code that >> assumes gcc specific things based on #ifdef __i386__ and friends... >> >> With that in mind, does this look good to land? >> > > This patch also removes the #error lines from all the intrinsics headers. > Did you intend that to be part of this patch? It's a good idea, but the > backend actually asserts when they are used, like David said. > Those are actually the changes I had to make to make the tests pass with my patch. These headers currently use the gcc style target dependent macros in order to decide whether or not to #error and we have tests that hit the #error situation (or hit unknown types because we don't include some headers based on these macros if you #include "immintrin.h" for example). If there is a better way to fix these issues, I'd be happy to do that instead. Cheers, -- Ehsan <http://ehsanakhgari.org/>
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
