The global_ctors patch seems fine, but I think David approved the previous patch prematurely.
The initializer code on Windows is already in its own comdat while the global_ctors entry is in the comdat with the global. We should leave that as is. I also think you need to put the the global (the key) into a proper comdat, and not just leave it as a linkonce_odr global. On Thu, Sep 18, 2014 at 5:06 PM, Rafael Espíndola < [email protected]> wrote: > On 18 September 2014 19:35, Reid Kleckner <[email protected]> wrote: > > We should also omit the third entry in @llvm.global_ctors. > > How about the attached patch for clang? > > Cheers, > Rafael >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
