I think we want this comdat grouping on mingw. Unlike C5/D5, the global variable is a real symbol that is a member of the comdat group. I think the check should still be !MachO, but the code that sets the comdat of the global and the initializer function needs to be sunk into the ItaniumCXXABI.cpp code.
On Thu, Sep 18, 2014 at 7:13 PM, Rafael Espíndola < [email protected]> wrote: > On 18 September 2014 21:52, Reid Kleckner <[email protected]> wrote: > > The global_ctors patch seems fine, but I think David approved the > previous > > patch prematurely. > > > > The initializer code on Windows is already in its own comdat while the > > global_ctors entry is in the comdat with the global. We should leave > that as > > is. > > > > I also think you need to put the the global (the key) into a proper > comdat, > > and not just leave it as a linkonce_odr global. > > Something like this? > > Cheers, > Rafael >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
