lgtm On Fri, Sep 19, 2014 at 10:50 AM, Rafael Espíndola < [email protected]> wrote:
> On 19 September 2014 12:57, Reid Kleckner <[email protected]> wrote: > > I think we want this comdat grouping on mingw. Unlike C5/D5, the global > > variable is a real symbol that is a member of the comdat group. I think > the > > check should still be !MachO, but the code that sets the comdat of the > > global and the initializer function needs to be sunk into the > > ItaniumCXXABI.cpp code. > > Make sense. The attached patch does all the work from > lib/CodeGen/ItaniumCXXABI.cpp. > > Cheers, > Rafael >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
