On Jun 22, 2012, at 7:00 PM, João Matos wrote: > Hi Charles, > > Patch looks fine to me. Thanks for the vote of confidence, but I'm really waiting for a word from John, who owns the IR Generator (cf. http://llvm.org/docs/DeveloperPolicy.html ).
Chip > > On Sat, Jun 23, 2012 at 1:43 AM, Charles Davis <[email protected]> > wrote: >> Ping... >> >> On Jun 16, 2012, at 5:00 AM, Charles Davis wrote: >> >>> >>> On Jun 15, 2012, at 2:01 PM, r4start wrote: >>> >>>> On 15/06/2012 23:05, Eli Friedman wrote: >>>>> On Fri, Jun 15, 2012 at 11:49 AM, Charles Davis <[email protected]> >>>>> wrote: >>>>>> Hi, >>>>>> >>>>>> This patch factors v-table generation into the CGCXXABI class, so that, >>>>>> in the future, the Microsoft C++ ABI can implement its own v-table >>>>>> generation. >>>>>> >>>>>> I also had to move the ItaniumCXXABI class into a header, so that CGRTTI >>>>>> could continue to use the getVTableLinkage() method, which now lives in >>>>>> ItaniumCXXABI. I thought that since CGRTTI is specific to the Itanium >>>>>> ABI anyway, this was OK. I don't know if you would prefer that method >>>>>> continue to belong to CodeGenModule, but I imagine that the Microsoft >>>>>> C++ ABI may have different rules for v-table visibility (which I have >>>>>> yet to work out). >>>>>> >>>>>> OK to commit? >>>>> Do you really need a different implementation of getVTableLinkage for >>>>> the Microsoft ABI? It doesn't look like it actually does anything >>>>> ABI-specific. >>> Moved it back. >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > > > -- > João Matos _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
