Ideally without copying code, I think we should implement the strategy Timur, John and I discussed where there is a flag to enable Itanium-fallback in the MS ABI to cover cases where that is sufficient for forward progress.
On Thu, Jun 28, 2012 at 5:07 PM, João Matos <[email protected]> wrote: > The fix is easy: Copy the code from the Itanium case to the Microsoft > one. While it's not correct, it matches the old behaviour while > keeping the abstraction of this patch. > > On Fri, Jun 29, 2012 at 12:24 AM, Timur Iskhodzhanov > <[email protected]> wrote: > > FYI, by "regression" I meant there was a functionality which was not > > broken but rather disabled as a whole :) > > > > On Thu, Jun 28, 2012 at 4:21 PM, Chandler Carruth <[email protected]> > wrote: > >> Regressions are not OK. Unless the fix is imminent, we should revert and > >> work on a correct patch. > >> > >> > >> On Thu, Jun 28, 2012 at 4:08 PM, Timur Iskhodzhanov < > [email protected]> > >> wrote: > >>> > >>> FTR, this patch has regressed: > >>> http://llvm.org/bugs/show_bug.cgi?id=13231 > >>> > >>> Now I can't build non-trivial C++ code anymore. > >>> [I had local patches to work OK on some files and was planning to send > >>> a few things for review but now I'm literally stuck at ~r158985] > >>> > >>> Please fix this ASAP or I'll have to revert it (locally, maybe; but > >>> this is still not cool). > >>> > >>> On Sat, Jun 23, 2012 at 4:50 PM, Charles Davis < > [email protected]> > >>> wrote: > >>> > > >>> > On Jun 23, 2012, at 1:11 PM, John McCall wrote: > >>> >> The remaining trivial patch, which just declares, defines, and calls > >>> >> EmitVTables, is approved. > >>> > Thanks, r159091. > >>> > > >>> > Chip > >>> > > >>> > > >>> > _______________________________________________ > >>> > cfe-commits mailing list > >>> > [email protected] > >>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >>> _______________________________________________ > >>> cfe-commits mailing list > >>> [email protected] > >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >> > >> > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > > -- > João Matos >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
