Test cases are required for this sort of thing. Also, you're not checking whether it has the __ptr64 attribute before performing the mangle, are you sure that's what you want? Is there a __ptr32 mangle we should be emitting if the pointer width is 32?
~Aaron On Mon, Nov 5, 2012 at 4:51 PM, pravic <[email protected]> wrote: > Hi cdavis5x, > > Add "__ptr64" qualifier under X64 mode as VC++ does. > > > http://llvm-reviews.chandlerc.com/D101 > > Files: > lib/AST/MicrosoftMangle.cpp > > Index: lib/AST/MicrosoftMangle.cpp > =================================================================== > --- lib/AST/MicrosoftMangle.cpp > +++ lib/AST/MicrosoftMangle.cpp > @@ -1218,6 +1218,10 @@ > Out << 'U'; > else > Out << 'Q'; > + > + // mangle __ptr64 > + if (getASTContext().getTargetInfo().getPointerWidth(0) == 64) > + Out << 'E'; > } > } else > Out << 'Y'; > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
