The line endings still appear to be messed up in the patch.

As for the type attributes, I would expect to see a Ptr64Attr or
Ptr32Attr for them.  You can start following the logic in
SemaDeclAttr.cpp handlePortabilityAttr to see whether they are being
properly applied to the declaration.  I'm not certain why they would
be dropped, but it could be a latent bug.

~Aaron

On Tue, Nov 6, 2012 at 9:13 AM, pravic <[email protected]> wrote:
>   Added tests for __ptr64 and __ptr32 qualifiers (and corrected line endings).
>
>   These tests were failed because explicit qualifiers doesn't implemented in 
> mangling.
>
>   Can someone tell me, how to access the AttributeList of mangled type to 
> check declaration for AttributeList::AS_MSTypespec. Because NamedDecl doesn't 
> have any attributes (.hasAttrs() == false).
>
> Hi cdavis5x,
>
> http://llvm-reviews.chandlerc.com/D101
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D101?vs=270&id=271#toc
>
> Files:
>   lib/AST/MicrosoftMangle.cpp
>   test/CodeGenCXX/mangle-ms-ptr64.cpp
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to