This version changes the line endings of MicrosoftMangle.cpp (so it appears as though the whole file changes). Can you ensure the line endings stay consistent and resubmit?
Your test cases look like a good start to me, but if this is about __ptr64 support I would like to see some explicit cases for it, such as how int * __ptr32 p32; int * __ptr64 p64; are mangled (they would make reasonable parameters, for instance). Thanks! ~Aaron On Tue, Nov 6, 2012 at 7:34 AM, pravic <[email protected]> wrote: > Added tests > > Hi cdavis5x, > > http://llvm-reviews.chandlerc.com/D101 > > CHANGE SINCE LAST DIFF > http://llvm-reviews.chandlerc.com/D101?vs=263&id=270#toc > > Files: > lib/AST/MicrosoftMangle.cpp > test/CodeGenCXX/mangle-ms-ptr64.cpp > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
