LGTM.
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:142
@@ -141,1 +141,3 @@
+ /// EmitFullMemberPointer - Emits a full member pointer with the fields
common
+ /// data and function member pointers.
----------------
with the fields common *to*
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:552
@@ +551,3 @@
+
+ // The rest of the fields are adjusted by conversions to a more derived
class.
+ if (hasNonVirtualBaseAdjustmentField(IsMemberFunction, Inheritance))
----------------
Maybe we should leave a FIXME: with a link to the PR?
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:604
@@ +603,3 @@
+MicrosoftCXXABI::EmitMemberPointer(const APValue &MP, QualType MPT) {
+ llvm_unreachable("const expr member pointer conversions not implemented in "
+ "the MS ABI");
----------------
What exactly are "const expr member pointer conversions"?
http://llvm-reviews.chandlerc.com/D699
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
