Thanks, going to commit this. One thing I noticed after hacking on the successor was that two of the fields are out of order. I added a test where you can see the difference.
On Tue, Apr 30, 2013 at 9:31 PM, Charles Davis <[email protected]> wrote: > > Other than one small nit, LGTM. But (as you well know) @rjmccall has the > final say here :). > > > ================ > Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:142 > @@ -141,1 +141,3 @@ > > + /// EmitFullMemberPointer - Emits a full member pointer with the fields > common > + /// to data and function member pointers. > ---------------- > I recommend using `\brief` instead of repeating the method's name in the > doc-comment like that. > > > http://llvm-reviews.chandlerc.com/D699 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
