Other than one small nit, LGTM. But (as you well know) @rjmccall has the 
final say here :).


================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:142
@@ -141,1 +141,3 @@
 
+  /// EmitFullMemberPointer - Emits a full member pointer with the fields 
common
+  /// to data and function member pointers.
----------------
I recommend using `\brief` instead of repeating the method's name in the 
doc-comment like that.


http://llvm-reviews.chandlerc.com/D699
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to