Chatted with David and Iain about these on IRC a bit. They are OK for inclusion in 3.4.1.
-Jim On Apr 9, 2014, at 3:30 PM, David Fang <[email protected]> wrote: > Hi Tom, > Thanks for committing most of these to 3.4.1! > > Just two remain: > LLVM: > r196970 [mine] -- .weak_definition vs. .weak_def_can_be_hidden (legacy asm) > > Clang: > r196981 [mine] -- suppress -Q for legacy system assembler (driver) > > I have been using both of these in my own fink packages of llvm/clang on OS X > 10.4 through 10.7 since the initial 3.4 release. > > Are these OK for 3.4.1? Jim? > When you announce a branch freeze or release candidate, I'll do another merge > to my own legacy support branches and test. > > David > >> On 28 March 2014 22:19, David Fang <[email protected]> wrote: >>> Hi Tom, >>> Thanks for doing this. I would like to nominate the following >>> patches to be backported to release_34 (3.4.1). >>> >>> LLVM: >>> r196168, r196970 -- .weak_definition vs. .weak_def_can_be_hidden >>> (r196168 is Rafael's, 970 is mine) >>> r196987, r197572, r197574 -- [ABI] f64,i64 alignment on ppc-darwin >>> all Rafael's, 196987 is a cosmetic change that made it easier >>> to apply the others. >>> r198744 [Iain Sandoe] -- FDE cross-section relocs for EH >>> >>> https://github.com/fangism/llvm/tree/powerpc-darwin8-rel-3.4 >>> >>> - - - - - - - - - - - - - - - - - - >>> Clang: >>> r197577 [Rafael] -- f64 alignment ppc-darwin struct layout >>> r196981 [me] -- suppress -Q for legacy system assembler >>> >>> https://github.com/fangism/clang/tree/powerpc-darwin8-rel-3.4 >>> >> >> For what it is worth, I think this is fine. The changes are either low >> risk for being ppc-darwin local or are simple cleanups. >> >> Cheers, >> Rafael >> > > -- > David Fang > http://www.csl.cornell.edu/~fang/
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
