On 23 May 2014 09:04, "Tobias Grosser" <[email protected]> wrote: > > On 23/05/2014 09:02, Alexander Kornienko wrote: >> >> Slightly shorter and more expensive, I would say. > > > It is just a minor change, but more expensive? That does not sound beneficial?
s/expensive/expressive/ (Android keyboard...) > > Also, you missed this question: > > >>> } >>>> >>>> } >>>> return llvm::make_error_code(llvm::errc::not_supported); >>>> >>> >>> Should this line be changed too? AFAIK, there's no shortcut for this error code. Success code is special, it has a dedicated static member for simplicity and expressiveness. > > > Cheers, > Tobias
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
