Szelethus added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1487 - if (Att->getModule()->getName() != - MemFunctionInfo.CD_malloc.getFunctionName()) + if (Att->getModule()->getName() != "malloc") return nullptr; ---------------- NoQ wrote: > Szelethus wrote: > > Ugh, no idea whats happening here, I'll be honest. I sweat to dig a bit > > deeper to find out, though I didn't want to bother delaying the publishing > > this patch for a feature not documented, or used anywhere. > I think this is about the (lack of) support for `__attribute__((malloc))`. This should be an NFC change, and this part of the code will have to be rewritten anyways if we want a more serious annotation guided analysis. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68165/new/ https://reviews.llvm.org/D68165 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits