aaron.ballman added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10076 +def warn_sycl_kernel_num_of_template_params : Warning< + "'sycl_kernel' attribute only applies to template functions with at least" + " two template parameters">, InGroup<IgnoredAttributes>; ---------------- Do you mean template function or function template? A function template is a template used to generate functions and a template function is a function produced by a template. I think you probably mean "function template" here. ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10079-10080 +def warn_sycl_kernel_invalid_template_param_type : Warning< + "template parameter of template functions with 'sycl_kernel' attribute must" + " be typename">, InGroup<IgnoredAttributes>; +def warn_sycl_kernel_num_of_function_params : Warning< ---------------- This diagnostic reads a bit like you cannot do this: `template <class N>` when I think the actual restriction is that you cannot do this: `template <int N>`. Is that correct? If so, I think this could be worded as `template parameter of a function template with the 'sycl_kernel' attribute must be a template type parameter`. Just double-checking, but you also intend to prohibit template template parameters? e.g., you can't do `template <template <typename> typename C>` ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10082 +def warn_sycl_kernel_num_of_function_params : Warning< + "template function with 'sycl_kernel' attribute must have single parameter">, + InGroup<IgnoredAttributes>; ---------------- Probably "function template" here as well. ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10085 +def warn_sycl_kernel_return_type : Warning< + "template function with 'sycl_kernel' attribute must return void type">, + InGroup<IgnoredAttributes>; ---------------- Same here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
