bader marked an inline comment as done. bader added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2477 + if (LangOpts.SYCLIsDevice && Global->hasAttr<SYCLKernelAttr>()) { + // SYCL kernels can be templated and not called from anywhere in the ---------------- ABataev wrote: > Need to check if the decl must be emitted at all. Let me check that I get it right. You suggest adding `if (MustBeEmitted(Global))`, right? ``` if (LangOpts.SYCLIsDevice && Global->hasAttr<SYCLKernelAttr>() && MustBeEmitted(Global)) { ... addDeferredDeclToEmit(GD); return; } ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits