bader marked an inline comment as done. bader added inline comments.
================ Comment at: clang/test/Misc/pragma-attribute-supported-attributes-list.test:134 // CHECK-NEXT: ReturnsTwice (SubjectMatchRule_function) +// CHECK-NEXT: SYCLKernel (SubjectMatchRule_function) // CHECK-NEXT: ScopedLockable (SubjectMatchRule_record) ---------------- It looks like this change is not needed anymore. This check fails on my machine with the latest version of the patch. @aaron.ballman, I'm not sure if this is a problem of the implementation or test issue. Do I understand correctly that this test validates the list of the attributes which can be applied using `#pragma clang`? If so, removing this check seems to be okay. We need only `[[clang::sycl_kernel]]` or `__attribute__((sycl_kernel))` to work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits