logan-5 added a comment. In D84244#2164537 <https://reviews.llvm.org/D84244#2164537>, @Quuxplusone wrote:
> For GTest and GMock specifically, it would be a good medium-term idea to try > to upstream patches into those libraries. I did eventually have success > upstreaming fixes for `-Wdeprecated` into GTest, for example: > https://github.com/google/googletest/pull/2815 Nice, that's encouraging. That does sound like a good solution for slightly further down the road. > (Although I'm a bit confused; I thought `-Wsuggest-override` was > off-by-default? Is it part of `-Wall`, and do unittests add `-Wall` to their > command line or something?) After I implemented the warning and it landed, people wanted it explicitly turned on in the LLVM build, so then I did that. This is part of the fallout from that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84244/new/ https://reviews.llvm.org/D84244 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
